plugins icon indicating copy to clipboard operation
plugins copied to clipboard

Support signed commit in `trunk-io/trunk-action/upgrade`

Open yu-iskw opened this issue 9 months ago • 3 comments

Let me open the feature request in the repository, since trunk-io/trunk-action doesn't allow me to create issues.

Currently, trunk-io/trunk-action/upgrade doesn't support signed commit. If we turn on the setting that commit is required in a GitHub repository, the check doesn't pass. So, it would be great to support signed commit in the action.

image

yu-iskw avatar May 02 '24 02:05 yu-iskw

Hi @yu-iskw! Thanks for bringing this up! I'll talk to the owning team about making sure that repo supports issues.

In the meantime, we'll look into seeing if we can get signed commits working for that action.

TylerJang27 avatar May 02 '24 17:05 TylerJang27

@yu-iskw we've released trunk-io/trunk-action/[email protected], which has an option for signoff. This should be sufficient for the DCO app.

If this is insufficient and you also need the commit to be signed and verified, please let us know and we can look into supporting that.

TylerJang27 avatar May 08 '24 18:05 TylerJang27

@TylerJang27 Thank you so much. I will give it a try.

yu-iskw avatar May 23 '24 13:05 yu-iskw