plugins icon indicating copy to clipboard operation
plugins copied to clipboard

Adding some of the most common php tooling

Open matthewbaggett opened this issue 1 year ago • 2 comments

  • phpunit for running unittests
  • paratest for running the same unitests in parallel
  • php-cs-fixer for enforcing formatting.

php-cs-fixer could be considered to be promoted to being a linter as soon as I work out how to parse its output and feed it through a post-processor like phpstan is.

matthewbaggett avatar Apr 26 '24 00:04 matthewbaggett

⏱️ 5m total CI duration on this PR
Job Cumulative Duration Recent Runs
CodeQL-Build 1m 🟩
Trunk Check runner [linux] 1m 🟩
Windows Tool Tests 48s 🟥
Repo Tests / Plugin Tests 39s 🟩
Tool Tests (ubuntu-latest) 33s 🟥
Tool Tests (macOS) 13s 🟥
Detect changed files 7s 🟩
Aggregate Test Results 1s 🟥

settingsfeedbackdocs ⋅ learn more about trunk.io

trunk-io[bot] avatar Apr 26 '24 00:04 trunk-io[bot]

Hi Matthew, thank you so much for taking the lead here on integrating these tools. In order to get them to pass, would you mind adding health checks and unit tests? You can look at These are very simple. Let me/us know if you have any trouble.

I'd do it myself but you're using a fork, not a branch :)

example: https://github.com/trunk-io/plugins/blob/main/tools/clangd/plugin.yaml#L20

laurit17 avatar Apr 26 '24 18:04 laurit17

@matthewbaggett - thanks for opening this pull request. would love to get these landed. do you need more guidance to get the tests in place?

EliSchleifer avatar May 13 '24 18:05 EliSchleifer

Hi @matthewbaggett! We'd like to get more php usage in soon, so I'll push some basic testing code to your branch or to a fork by the end of the week to try and get this in

TylerJang27 avatar May 21 '24 17:05 TylerJang27

@matthewbaggett I've gone and added the dependencies and tests to get this working. Can you try php-cs-fixer out and make sure it conforms to your original needs/idiomatic usage? Otherwise I will land this tomorrow.

TylerJang27 avatar May 22 '24 23:05 TylerJang27