plugins icon indicating copy to clipboard operation
plugins copied to clipboard

RFC: Support [email protected]

Open TylerJang27 opened this issue 10 months ago • 3 comments

[email protected] was released and with it a major change to how eslint is configured. The migration process is nontrivial and may not be an option/priority for every project. Additionally, upgrading will loudly fail unless you have accounted for the config. Accordingly, I have done the following:

  • Make direct_configs a property of commands, allowing us to version the configs that are applicable for linter
    • Users will only be upgraded/init'd/enabled at compatible versions with their config
  • Modify the eslint tests to handle pre- and post- eslint9
  • Upgrade this repo to use an eslint9 flat config
  • Perform an audit and address a handful of the new diagnostics coming from eslint9

This will require a version bump and minimum requirement increase to support.

TylerJang27 avatar Apr 09 '24 23:04 TylerJang27

Ultimately, there are 2 existing issues warranting this change (or a similar one):

  1. LUV cannot safely upgrade a user on [email protected] to [email protected], since it will 100% break said user, even with the environment variable override that doesn't really work
  2. If we detect an eslint config, we need to know which version of eslint to enable at. Having an @package would alleviate this issue

TylerJang27 avatar Apr 11 '24 23:04 TylerJang27

💊 0 quarantined ✅ 261 passed 🕐 266 new ⋅ (learn more)

docs ⋅ learn more about trunk.io

trunk-staging-io[bot] avatar May 09 '24 09:05 trunk-staging-io[bot]

@det Plan for release since older CLI versions will naively respect LUV, AND also won't have the direct_configs update here:

  1. Land this
  2. Follow-up with a patch that omits eslint from LUV uploading
  3. Release plugins
  4. Let it marinate for ~1 week so that the newest LUV will stay at 8.57.0
  5. Revert the patch so that LUV will have the correct newest validated eslint version

The patch is only necessary for extra caution, in case someone is on a new CLI version but not a new plugins version (or on an old CLI version).

TylerJang27 avatar May 28 '24 21:05 TylerJang27