Andrew Bullock

Results 166 comments of Andrew Bullock

Thanks for the example As per the readme and above, I've not got the time to fix this. PRs welcome

Because the current default functionality is to always remove them, right? And you want the option to keep them?

For CSS you can use `CssSettings.CommentMode`, but for JS theres only the option to keep important comments

Comments that start with `//!` or `/*!`, you usually see them at the top of libs with the license info in it Not an official syntax but commonly adopted

This has uncovered a bug whereby prologue directives are broken by there being preceeding important comments in the block. This needs fixing, might as well be along with this ticket...

Added a PR for this, please have a play and see if this meets your needs

Yeah, can you test the PR meets your needs?

Whats missing from the docs is what pins to use, which are: ``` bclkPin = 26; wclkPin = 25; doutPin = 22; ```

@sudarshann These are already defined (hard coded) inside this library, see here https://github.com/earlephilhower/ESP8266Audio/blob/9dd4f24056821a2591f825c743d152bab862984a/src/AudioOutputI2S.cpp#L46