truffle icon indicating copy to clipboard operation
truffle copied to clipboard

Debugger txlog should include raw data for external calls and returns somehow

Open haltman-at opened this issue 3 years ago • 1 comments

Issue

I recently added raw data for events in the txlog (#5324). This suggests that the same should happen for calls and returns (presumably just external calls/returns, the idea doesn't make a lot of sense for internal calls and returns).

How this would work would have to be figured out, though. For calls it makes sense to attach it to the callexternal action. But what about for returns? One could attach it to the same action, but that doesn't mesh well with how txlog is designed -- consider where error decodings go; they don't go on the external call, they go on the internal call that threw! This stems from the original intent that txlog would be used as the basis for a visualizer.

So assuming we're not redoing that (and I don't want to redo that!), we'd need to determine where the raw return data would go. Although I suppose I could possibly implement raw call data without that...?

Environment

  • Truffle version (truffle version): 5.5.22

haltman-at avatar Jul 20 '22 19:07 haltman-at

(The call data part of this is now done; see #5391 for more details.)

haltman-at avatar Aug 05 '22 01:08 haltman-at