ganache icon indicating copy to clipboard operation
ganache copied to clipboard

feat: get logs from a fork network directly

Open adjisb opened this issue 2 years ago • 4 comments

adjisb avatar Sep 20 '22 16:09 adjisb

This looks like it's not quiet ready for review as you've introduced some new TODOs

davidmurdoch avatar Sep 28 '22 18:09 davidmurdoch

Ok, I will remove the TODOs, they are related to some bugs in the block-manager.ts and can be fixed in other PRs.

adjisb avatar Sep 28 '22 19:09 adjisb

Ok, I will remove the TODOs, they are related to some bugs in the block-manager.ts and can be fixed in other PRs.

What are the bugs?

davidmurdoch avatar Sep 28 '22 21:09 davidmurdoch

getNumberFromHash is called from api.eth_getBlockTransactionCountByHash but it doesn't support forks, so I used getByHash. BlockManager.earliest also doesn't support forks or at least doesn't point to the earliest block of the forked network. I tried to minimize the changes outside blocklog-manager.ts

adjisb avatar Sep 28 '22 21:09 adjisb