ganache icon indicating copy to clipboard operation
ganache copied to clipboard

fix: use zero address when unable to calculate 'from'

Open gBaGu opened this issue 3 years ago • 6 comments

I'm trying to fork a evm-compatible chain with ganache-ui, but my chain contains custom signatures and when block that is used as a fork point has transaction with custom signature ganache application crashes on Transactions screen. The problem comes from Transaction.from getter function which throws if signature is invalid and causes ui to crash. This PR simply uses zero address as 'from' field instead of throwing an exception.

gBaGu avatar Sep 15 '22 10:09 gBaGu

Ganache-UI hasn't been updated to use the latest version of Ganache. Your fix here would certainly make UI stop crashing... but would ultimately just make the implementation completely incorrect.

davidmurdoch avatar Sep 15 '22 15:09 davidmurdoch

Is there another way to handle invalid signatures without crashing?

gBaGu avatar Sep 15 '22 17:09 gBaGu

Does Ganache v7 (npm install ganache --global and then run ganache --fork.url <YOUR URL HERE>) return errors when you try to use it?

What chain are you using?

davidmurdoch avatar Sep 15 '22 18:09 davidmurdoch

@davidmurdoch cli Ganache works fine. So my only option is to use command line Ganache instead of UI? I'm using Velas chain

gBaGu avatar Sep 21 '22 12:09 gBaGu

Ganache UI hasn't been updated yet.

davidmurdoch avatar Sep 21 '22 15:09 davidmurdoch

@davidmurdoch will it be updated any time soon?

gBaGu avatar Sep 28 '22 14:09 gBaGu