webui icon indicating copy to clipboard operation
webui copied to clipboard

NAS-134539 / 25.04.1 / Re-initialize `VirtualizationInstancesStore` after config form closes (by RehanY147)

Open bugclerk opened this issue 8 months ago • 1 comments

Automatic cherry-pick failed. Please resolve conflicts by running:

git reset --hard HEAD~1
git cherry-pick -x b4e888e964a372f5d75ab5846f3828791d94a994
git cherry-pick -x 7340566bc2ebb3022e062a3bc39446c457b2ec9c
git cherry-pick -x 0dcba36d574cb1d55c50e9706a0e421bd377e927
git cherry-pick -x a83c455cf5875c50b1baeca38ca7cb30be0544af
git cherry-pick -x 318b7323b999944c587967679ff412b46b621fca
git cherry-pick -x b3984fdcb458010657f21643ffe2946b3fa61e14
git cherry-pick -x 033bff89f8d63d6c0740c48a88c8bba8fb9bddc5
git cherry-pick -x 2ad38d1e525d9c92a82fafff80f9cd91786403ea
git cherry-pick -x c4a05aa78548862025b47d8bc3a775a75f116be9
git cherry-pick -x e20e9723889a1dc090fd90f5982f5f33b5a87a04
git cherry-pick -x a74cabdf9a70a143adab36ed7a842da4d904d101
git cherry-pick -x ddbd0c6d5f9375b929ca80af6d8da3d29526c4ee
git cherry-pick -x 49dfcf2cf8e48e246d28739d2ec6f920bfdde07b
git cherry-pick -x 4e40d3585b793826e3b181f4fbd233318d0a50a8
git cherry-pick -x c15ca846401caf2867908f3ee5e8317ae1a1297b
git cherry-pick -x bd3b35ecbdedf2bbe8066b99b2b54a2814aa9ebf
git cherry-pick -x 1ed75bd035544174a09096f0cf821f81f5fa01ad
git cherry-pick -x fe065b1722e44a7b75d65abd1f5cf612aa618062
git cherry-pick -x 21349e2aa5f29a85b89c5a71716541e1b750be42
git cherry-pick -x e7ca95a4fa7f7e2fe134880adefc77364583c6ce
git cherry-pick -x b83f92b0ffbefbe38bb69100784bdbbb735fbd5a

If the original PR was merged via a squash, you can just cherry-pick the squashed commit:

git reset --hard HEAD~1
git cherry-pick -x f66e58bf744760468a31c9feb4c67afd7cbddec2

Changes:

Re-initializes store state after config form closes to reload data if pool was changed.

Testing:

1- Select pool 2- Create an instance 3- Export selected pool 4- Import the pool back 5- Go to instances page and select the pool again

The instance that was created before exporting the pool should automatically load after the pool is selected again and the form is closed.

Original PR: https://github.com/truenas/webui/pull/11707 Jira URL: https://ixsystems.atlassian.net/browse/NAS-134539

bugclerk avatar Mar 31 '25 10:03 bugclerk

Codecov Report

Attention: Patch coverage is 84.00000% with 16 lines in your changes missing coverage. Please review.

Please upload report for BASE (stable/fangtooth@8e3a080). Learn more about missing BASE report.

:white_check_mark: All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...instances/stores/virtualization-instances.store.ts 80.00% 11 Missing :warning:
...s/instances/stores/virtualization-devices.store.ts 50.00% 4 Missing :warning:
...omponents/all-instances/all-instances.component.ts 50.00% 1 Missing :warning:
Additional details and impacted files
@@                 Coverage Diff                 @@
##             stable/fangtooth   #11813   +/-   ##
===================================================
  Coverage                    ?   83.19%           
===================================================
  Files                       ?     1664           
  Lines                       ?    59484           
  Branches                    ?     6281           
===================================================
  Hits                        ?    49486           
  Misses                      ?     9998           
  Partials                    ?        0           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Apr 03 '25 07:04 codecov[bot]

This PR has been merged and conversations have been locked. If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

bugclerk avatar Apr 07 '25 10:04 bugclerk