NAS-131326 / 25.04 / Simplify HA upgrade logic + NAS-131325: `system.reboot.info` and `failover.reboot.info` methods and events
Changes:
This PR contains changes for 2 tickets
-
NAS-131325:
system.reboot.infoandfailover.reboot.infomethods and eventshere's what's implemented for this ticket:
- Calling new endpoints
system.reboot.infoandfailover.reboot.infobased on whether system is HA licensed, - Showing Reboot Info non-blocking notification in the top right corner:
(if there are items in the
reboot_required_reasonsfield, the following dialog should appear)
- Calling new endpoints
-
NAS-131326: Simplify HA upgrade logic
here's what's implemented for this ticket:
- usages of
failover.upgrade_pendingandfailover.upgrade_finishmethods and events were removed, they are not necessary anymore - webUI calls with
failover.upgrademethod and waits for middleware to upgrade both local and remote controllers, then reboots the remote controller and wait it to come online, then webUI will display a reboot reason (see pt "1" in the description of this PR) - UI only calls
failover.become_passivewhen the user is ready to reboot the local controller, and thus the upgrade will be finished.
- usages of
Testing:
-
NAS-131325:
system.reboot.infoandfailover.reboot.infomethods and eventsTo test the
system.reboot.infoandfailover.reboot.infomethods and events, follow these steps:Login into the HA-enabled server, for example at M40 (10.220.16.82)
Expected result: When logging into the HA system, a call to
failover.reboot.infomust be made, and then a subscription tofailover.reboot.info. For non-HA - the same thing, onlysystem.reboot.info.-
If the call response or subscription contains items in
reboot_required_reasons, a dialog is shown with a proposal to restart the corresponding node. -
However, if the
failover.disabled.reasonsresponse contains reasons other thanMISMATCH_VERSIONS,LOC_FIPS_REBOOT_REQorREM_FIPS_REBOOT_REQ, the dialog is not shown.
-
-
NAS-131326: Simplify HA upgrade logic
To test the
failover.upgradejob, follow these steps:- Login into the HA-enabled server, for example at M40 (10.220.16.82)
- Go to System > Update
- Choose Manual Update , reject a prompt to make a backup, and choose the .update file
- In a new browser tab go to Dashboard page (or any other page)
Now you can see the Reboot Info notification, shown in pt "1" of the description of this PR.
Downstream
| Affects | Reasoning |
|---|---|
| Documentation |
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 81.94%. Comparing base (
8766977) to head (506bccb). Report is 1 commits behind head on master.
Additional details and impacted files
@@ Coverage Diff @@
## master #10744 +/- ##
==========================================
+ Coverage 81.80% 81.94% +0.14%
==========================================
Files 1626 1627 +1
Lines 57324 57296 -28
Branches 5920 5923 +3
==========================================
+ Hits 46892 46954 +62
+ Misses 10432 10342 -90
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Blocked by https://ixsystems.atlassian.net/browse/NAS-131916
@RehanY147 middleware issue has been resolved, now the dialog is displayed
@RehanY147 Now everything works as expected!
This PR has been merged and conversations have been locked. If you would like to discuss more about this issue please use our forums or raise a Jira ticket.