webui icon indicating copy to clipboard operation
webui copied to clipboard

NAS-131093 / 25.04 / Remove EntityJobComponent

Open undsoft opened this issue 1 year ago • 3 comments

Changes:

Removes last usages of EntityJobComponent.

Testing:

Test affected places.

undsoft avatar Sep 23 '24 11:09 undsoft

Jira URL: https://ixsystems.atlassian.net/browse/NAS-131093

bugclerk avatar Sep 23 '24 11:09 bugclerk

Codecov Report

Attention: Patch coverage is 30.23256% with 30 lines in your changes missing coverage. Please review.

Project coverage is 80.60%. Comparing base (48dded2) to head (e08262e). Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
...manual-update-form/manual-update-form.component.ts 20.00% 20 Missing :warning:
...date-actions-card/update-actions-card.component.ts 53.33% 7 Missing :warning:
src/app/services/session-timeout.service.ts 0.00% 3 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10733      +/-   ##
==========================================
+ Coverage   80.28%   80.60%   +0.32%     
==========================================
  Files        1571     1570       -1     
  Lines       51711    51509     -202     
  Branches     5840     5809      -31     
==========================================
+ Hits        41518    41521       +3     
+ Misses      10193     9988     -205     
Flag Coverage Δ
80.60% <30.23%> (+0.32%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Sep 23 '24 11:09 codecov[bot]

Yeah, forgot to remove the most important thing.

undsoft avatar Sep 26 '24 13:09 undsoft

This PR has been merged and conversations have been locked. If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

bugclerk avatar Sep 29 '24 09:09 bugclerk