webui icon indicating copy to clipboard operation
webui copied to clipboard

NAS-130055 / 24.10 / Updates catalog management & removes container image pages

Open RehanY147 opened this issue 1 year ago • 2 comments

Changes:

Updates catalog management. Also removes routes for Container Image settings components and removes all mentions as the API endpoint for those settings is going to change and until the new API is ready, we don't want to show broken UI. I've added TODO comments in each place where we should remember to add back stuff.

Testing:

Test catalog settings under the "Settings" button on the installed apps page. Look for "Manage Catalog" in the settings drop down (top right).

Downstream

Affects Reasoning
Documentation Adds catalog settings (preferred trains) on the installed apps page, removes container images page

RehanY147 avatar Jul 31 '24 20:07 RehanY147

Jira URL: https://ixsystems.atlassian.net/browse/NAS-130055

bugclerk avatar Jul 31 '24 20:07 bugclerk

Codecov Report

Attention: Patch coverage is 81.39535% with 8 lines in your changes missing coverage. Please review.

Project coverage is 77.17%. Comparing base (27e07b9) to head (a65555c). Report is 1 commits behind head on master.

Files Patch % Lines
...nts/catalog-settings/catalog-settings.component.ts 88.57% 4 Missing :warning:
...p-settings-button/app-settings-button.component.ts 60.00% 2 Missing :warning:
...rc/app/pages/apps/services/applications.service.ts 0.00% 2 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10384      +/-   ##
==========================================
- Coverage   77.17%   77.17%   -0.01%     
==========================================
  Files        1609     1610       +1     
  Lines       55015    55041      +26     
  Branches     6481     6480       -1     
==========================================
+ Hits        42460    42479      +19     
- Misses      12555    12562       +7     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jul 31 '24 21:07 codecov[bot]

This PR has been merged and conversations have been locked. If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

bugclerk avatar Aug 04 '24 09:08 bugclerk