webui icon indicating copy to clipboard operation
webui copied to clipboard

NAS-130213 / 24.10 / Add smaller apps widgets

Open denysbutenko opened this issue 1 year ago • 5 comments

Changes:

  1. Widget App Component was sliced into multiple small components
  2. Added widget-app-cpu (Quarter size)
  3. Added widget-app-memory (Quarter size)
  4. Added widget-app-info (Half size)
  5. Added widget-app-network (Half size)

image

Testing:

Check details in ticket

denysbutenko avatar Jul 31 '24 07:07 denysbutenko

Jira URL: https://ixsystems.atlassian.net/browse/NAS-130213

bugclerk avatar Jul 31 '24 07:07 bugclerk

One thing is missing. I'll notify when it is ready for review.

denysbutenko avatar Jul 31 '24 08:07 denysbutenko

Codecov Report

Attention: Patch coverage is 75.81699% with 37 lines in your changes missing coverage. Please review.

Project coverage is 76.91%. Comparing base (002da50) to head (0e2af84). Report is 2 commits behind head on master.

Files Patch % Lines
...ges/dashboard/services/widget-resources.service.ts 0.00% 8 Missing :warning:
...s/apps/widget-app-cpu/widget-app-cpu.definition.ts 0.00% 7 Missing :warning:
...apps/widget-app-info/widget-app-info.definition.ts 0.00% 7 Missing :warning:
.../widget-app-memory/widget-app-memory.definition.ts 0.00% 7 Missing :warning:
...idget-app-network/widget-app-network.definition.ts 0.00% 7 Missing :warning:
...d/widgets/apps/widget-app/widget-app.definition.ts 0.00% 1 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10378      +/-   ##
==========================================
- Coverage   76.93%   76.91%   -0.02%     
==========================================
  Files        1608     1622      +14     
  Lines       54996    55135     +139     
  Branches     6464     6473       +9     
==========================================
+ Hits        42309    42409     +100     
- Misses      12687    12726      +39     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Aug 03 '24 07:08 codecov[bot]

@AlexKarpov98, it's ready for review but blocked for testing. The recent changes in master branch break compatibility with the DF API. Waiting for adding support to make basic app CRUD actions.

denysbutenko avatar Aug 03 '24 07:08 denysbutenko

Tracking #10394 to be merged

denysbutenko avatar Aug 03 '24 07:08 denysbutenko

Since stats are unavailable, new widgets do not work. Half of widget-app can be tested only (app image, app version, app status)

denysbutenko avatar Aug 08 '24 03:08 denysbutenko

This PR has been merged and conversations have been locked. If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

bugclerk avatar Aug 09 '24 09:08 bugclerk