NAS-128628 / 24.10 / Add search elements for Application
Testing
See ticket
Jira URL: https://ixsystems.atlassian.net/browse/NAS-128628
Codecov Report
Attention: Patch coverage is 74.31193% with 196 lines in your changes are missing coverage. Please review.
Project coverage is 74.00%. Comparing base (
b0526d8) to head (f595969). Report is 23 commits behind head on master.
:exclamation: Current head f595969 differs from pull request most recent head ed626dd
Please upload reports for the commit ed626dd to get more accurate results.
Additional details and impacted files
@@ Coverage Diff @@
## master #10021 +/- ##
==========================================
+ Coverage 73.91% 74.00% +0.09%
==========================================
Files 1530 1550 +20
Lines 53515 54059 +544
Branches 6396 6476 +80
==========================================
+ Hits 39553 40007 +454
- Misses 13962 14052 +90
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
As well there is an issue with apps screen: Seems like it's redenders and hides searched elements because of it.
https://github.com/truenas/webui/assets/22980553/be11752e-716a-424e-b209-e410fae0dad6
@bvasilenko Let's do something about this PR.
This PR has been merged and conversations have been locked. If you would like to discuss more about this issue please use our forums or raise a Jira ticket.