webui icon indicating copy to clipboard operation
webui copied to clipboard

NAS-128628 / 24.10 / Add search elements for Application

Open bvasilenko opened this issue 1 year ago • 2 comments

Testing

See ticket

bvasilenko avatar May 02 '24 20:05 bvasilenko

Jira URL: https://ixsystems.atlassian.net/browse/NAS-128628

bugclerk avatar May 02 '24 20:05 bugclerk

Codecov Report

Attention: Patch coverage is 74.31193% with 196 lines in your changes are missing coverage. Please review.

Project coverage is 74.00%. Comparing base (b0526d8) to head (f595969). Report is 23 commits behind head on master.

:exclamation: Current head f595969 differs from pull request most recent head ed626dd

Please upload reports for the commit ed626dd to get more accurate results.

Files Patch % Lines
...storage/widget-storage/widget-storage.component.ts 71.62% 42 Missing :warning:
...ges/dashboard/services/widget-resources.service.ts 4.34% 22 Missing :warning:
...me-settings/widget-pool-name-settings.component.ts 30.00% 21 Missing :warning:
...ttings/widget-arbitrary-text-settings.component.ts 25.92% 20 Missing :warning:
...ponents/installed-apps/installed-apps.component.ts 0.00% 13 Missing :warning:
...settings/widget-interface-ip-settings.component.ts 20.00% 8 Missing :warning:
src/app/store/system-info/system-info.effects.ts 0.00% 7 Missing :warning:
.../directives/text-limiter/text-limiter.directive.ts 50.00% 5 Missing :warning:
...rc/app/pages/dashboard/services/dashboard.store.ts 0.00% 5 Missing :warning:
...ts-dashboard/components/report/report.component.ts 16.66% 5 Missing :warning:
... and 21 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10021      +/-   ##
==========================================
+ Coverage   73.91%   74.00%   +0.09%     
==========================================
  Files        1530     1550      +20     
  Lines       53515    54059     +544     
  Branches     6396     6476      +80     
==========================================
+ Hits        39553    40007     +454     
- Misses      13962    14052      +90     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar May 02 '24 20:05 codecov[bot]

As well there is an issue with apps screen: Seems like it's redenders and hides searched elements because of it.

https://github.com/truenas/webui/assets/22980553/be11752e-716a-424e-b209-e410fae0dad6

AlexKarpov98 avatar May 17 '24 05:05 AlexKarpov98

@bvasilenko Let's do something about this PR.

undsoft avatar May 28 '24 14:05 undsoft

This PR has been merged and conversations have been locked. If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

bugclerk avatar May 28 '24 20:05 bugclerk