truenas
NAS-138404 / 26.04 / fix: virt Dataset Creation AttributeError
Fixes NAS-138404. Looked into this as a user was running into issues on the discord, and I could repro.
When enabling containers in TrueNAS SCALE 26.04, users encounter an AttributeError: 'ZFSDatasetService' object has no attribute 'do_create'. This occurs because the virtualization service attempts to create ZFS datasets using a (now) non-existent zfs.dataset.create method.
Introduced by: 9ebe1ab8f3 - NAS-137905 / 26.04 / Remove zfs.dataset.create (#17326)
Fixed by:
Updated to use pool.dataset.create_impl
Fixes NAS-138404. Looked into this as a user was running into issues on the discord, and I could repro.
Thanks, that user was me, didn’t put it into Jira, because I wasn’t sure whether I was doing something wrong or if it’s bug, since I’m fairly new to TrueNAS. So I didn’t want to make any assumptions. Glad I wasn’t totally stupid and it’s being fixed😅
This entire plugin is being removed in https://github.com/truenas/middleware/pull/17032 hence why I never converted this file over. We're actively working on the container replacement and once that's complete, this will be gone.
Up to you on whether to merge or close this out -- I've got no input either way as I don't use the nightlies 😄
Reasonably simple change though, so might be worth including so container functionality isn't broken until this larger change is completed
This entire plugin is being removed in https://github.com/truenas/middleware/pull/17032 hence why I never converted this file over. We're actively working on the container replacement and once that's complete, this will be gone.
Ah! What will it be replaced with? Will existing containers be forward compatible? Approximate ETA?
This entire plugin is being removed in https://github.com/truenas/middleware/pull/17032 hence why I never converted this file over. We're actively working on the container replacement and once that's complete, this will be gone.
Ah! What will it be replaced with? Will existing containers be forward compatible? Approximate ETA?
Sorry for delay. We're just using a standard library (libvirt) for containers moving forward. Yes, existing containers should work with the replacement. There might be a few smaller bits that need to be manually tweaked.
Up to you on whether to merge or close this out -- I've got no input either way as I don't use the nightlies 😄
Reasonably simple change though, so might be worth including so container functionality isn't broken until this larger change is completed
Always appreciate the contributions, thanks!
Always appreciate the community PRs but as was mentioned earlier, this file has since been removed 😄 Going to close this. Thanks!