NAS-128404 / 24.10 / Improve file receive

Open yocalebo opened this issue 1 year ago • 2 comments

file_receive was susceptible to the TOCTOU race conditions when checking for a paths existence (or any path component) before opening said path. This should get rid of theoretical conditions and also switches to using the fchmod/fchown syscalls. I've also fixed a few flake8 issues while I'm here. There should be no functional change.

Apr 19 '24 11:04 yocalebo

Jira URL: https://ixsystems.atlassian.net/browse/NAS-128404

Apr 19 '24 11:04 bugclerk

I approved too quickly. Got spoofed by the latest simple update.

Apr 22 '24 18:04 mgrimesix

This PR has been merged and conversations have been locked. If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

May 07 '24 11:05 bugclerk