middleware icon indicating copy to clipboard operation
middleware copied to clipboard

NAS-127702 / 24.10 / Recursively mount root dataset during boot if it is not encrypted

Open umsaleem opened this issue 1 year ago • 2 comments

Import the pools during boot without mounting any of the datasets. Check on 'feature@encryption' for imported pool. If feature is not active, recursively mount the root datasets, which effectively mounts all datasets present on the pool.

If the encryption feature is active, continue and unlock the datasets.

umsaleem avatar Apr 15 '24 13:04 umsaleem

Jira URL: https://ixsystems.atlassian.net/browse/NAS-127702

bugclerk avatar Apr 15 '24 13:04 bugclerk

@sonicaj upstream merged changes where we can do zfs mount -R <root-dataset> to recursively mount from the parent dataset (including zpool). I've asked Umer to make the changes here at boot. Can you review for me please? Also, I do believe we have some quite complex handling in this area of our code related to encrypted zpools. Can we remove that with these changes? If we can, we should probably do in a separate PR but I'm not sure? I'll let you decide.

yocalebo avatar Apr 15 '24 14:04 yocalebo

This PR has been merged and conversations have been locked. If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

bugclerk avatar May 13 '24 18:05 bugclerk