charts icon indicating copy to clipboard operation
charts copied to clipboard

[metallb] "Open" button for apps still point to truenasIP with mlb enabled

Open ksimm1 opened this issue 2 years ago • 1 comments

App Name

metallb / common

SCALE Version

22.02.3

App Version

upstream_4.0.10

Application Events

N/A

Application Logs

N/A

Application Configuration

  1. Have metallb installed (and integrated loadbalancer disabled)
  2. Install any app with Simple service type
  3. Leave Ingress disabled

Describe the bug

The open button on an app in the SCALE GUI will try to open the app at http(s)://truenasIP:PORT rather than http(s)://metallb-assigned-IP:PORT

To Reproduce

To reproduce

  1. Have metallb installed (and integrated loadbalancer disabled)
  2. Install any app with Simple service type
  3. Leave Ingress disabled
  4. The open button will try to open the app at http://truenasIP:PORT rather than http://metallb-assigned-IP:PORT

Expected Behavior

The open button should use http://metallb-assigned-IP:PORT.

I and most others will avoid this issue mostly by using ingress. When ingress is defined the open button goes to the correct host/domain and the IP becomes irrelevant.

Screenshots

N/A

Additional Context

N/A

I've read and agree with the following

  • [X] I've checked all open and closed issues and my issue is not there.

ksimm1 avatar Sep 17 '22 02:09 ksimm1

Some notes:

  • We should add "LoadBalancerIP" to the "simple" servicetype
  • We can use that, if filled, for the portal button.

Sadly enough, there does not exist a simple way of getting the IP that is going to be assigned by metalLB at app creation time (the time the portal info is generated)

PrivatePuffin avatar Sep 17 '22 10:09 PrivatePuffin

While we can theoretically implement complicated ways to fetch the loadbalancer IP dynamically ish. Such a solution would be too complicated, cause many new issues and would actually have too-much of a failure rate.

Hence this cannot be implemented. We suggest to use ingress for everything.

PrivatePuffin avatar Feb 21 '23 10:02 PrivatePuffin

This issue is locked to prevent necro-posting on closed issues. Please create a new issue or contact staff on discord of the problem persists

truecharts-admin avatar Mar 01 '23 00:03 truecharts-admin