charts
charts copied to clipboard
feat(openproject): Enable memcached + push to stable
Feel like we need memcached if we want to move to Stable
Description
⚒️ Fixes #
⚙️ Type of change
- [X] ⚙️ Feature/App addition
- [X] 🪛 Bugfix
- [ ] ⚠️ Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] 🔃 Refactor of current code
🧪 How Has This Been Tested?
📃 Notes:
✔️ Checklist:
- [X] ⚖️ My code follows the style guidelines of this project
- [X] 👀 I have performed a self-review of my own code
- [X] #️⃣ I have commented my code, particularly in hard-to-understand areas
- [X] 📄 I have made corresponding changes to the documentation
- [ ] ⚠️ My changes generate no new warnings
- [ ] 🧪 I have added tests to this description that prove my fix is effective or that my feature works
- [X] ⬆️ I increased versions for any altered app according to semantic versioning
➕ App addition
If this PR is an app addition please make sure you have done the following.
- [ ] 🪞 I have opened a PR on truecharts/containers adding the container to TrueCharts mirror repo.
- [ ] 🖼️ I have added an icon in the Chart's root directory called
icon.png
Please don't blindly check all the boxes. Read them and only check those that apply. Those checkboxes are there for the reviewer to see what is this all about and the status of this PR with a quick glance.
Also: NEVER add features and move to stable at the same time ;-)
Also: NEVER add features and move to stable at the same time ;-)
Duly noted, passed CI so figured why not do both and see but yea makes sense, but makes sense from above that it passes CI if it's just starting memcached and not connecting it
Should be good to go now, but let me know if I’m missing anything
Can we remove the move to stable from the changes? Still is the case according to the PR title
@StevenMcElligott Open a ticket for that please and I'll get to it when I have some time!
Let's merge this so we can work later on it @Ornias1993
This PR is locked to prevent necro-posting on closed PRs. Please create a issue or contact staff on discord if you want to further discuss this