charts icon indicating copy to clipboard operation
charts copied to clipboard

feat(speedtest-tracker): Add Speedtest Tracker chart

Open alfi0812 opened this issue 11 months ago • 2 comments

Description

Added Speedtest-Tracker with the Image from LinuxServer.io which got recently released. https://github.com/alexjustesen/speedtest-tracker/issues/1117

⚙️ Type of change

  • [x] ⚙️ Feature/App addition
  • [ ] 🪛 Bugfix
  • [ ] ⚠️ Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [ ] 🔃 Refactor of current code

🧪 How Has This Been Tested?

Added App as Custom-App in a working state and checked with @StevenMcElligott

📃 Notes:

✔️ Checklist:

  • [x] ⚖️ My code follows the style guidelines of this project
  • [x] 👀 I have performed a self-review of my own code
  • [ ] #️⃣ I have commented my code, particularly in hard-to-understand areas
  • [ ] 📄 I have made corresponding changes to the documentation
  • [ ] ⚠️ My changes generate no new warnings
  • [ ] 🧪 I have added tests to this description that prove my fix is effective or that my feature works
  • [ ] ⬆️ I increased versions for any altered app according to semantic versioning

➕ App addition

If this PR is an app addition please make sure you have done the following.

  • [x] 🖼️ I have added an icon in the Chart's root directory called icon.png

Please don't blindly check all the boxes. Read them and only check those that apply. Those checkboxes are there for the reviewer to see what is this all about and the status of this PR with a quick glance.

alfi0812 avatar Feb 26 '24 16:02 alfi0812

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Feb 26 '24 16:02 CLAassistant

Looks good to me, at least for incubator testing for sure

StevenMcElligott avatar Feb 26 '24 18:02 StevenMcElligott

I'm on mobile, any reason for the ssl/web mount? I don't see it listed https://github.com/linuxserver/docker-speedtest-tracker

xstar97 avatar Feb 27 '24 06:02 xstar97

CACHE_DRIVER: redis Screenshot_20240227_021043_Chrome

xstar97 avatar Feb 27 '24 07:02 xstar97

I'm on mobile, any reason for the ssl/web mount? I don't see it listed https://github.com/linuxserver/docker-speedtest-tracker

https://docs.speedtest-tracker.dev/getting-started/installation/installation

It's mentioned in their Documentation. It's there so you can manually mount ssl certs. But I can remove it as ingress is the way truecharts does it. Edit: Removed the mount as it is now part of /config anyway.

alfi0812 avatar Feb 27 '24 08:02 alfi0812

CACHE_DRIVER: redis Screenshot_20240227_021043_Chrome

Working on it

alfi0812 avatar Feb 27 '24 09:02 alfi0812

Not sure if this is the correct way and there i no log of the container about the cache beeing redis. But it builds and seems to work.

alfi0812 avatar Feb 27 '24 09:02 alfi0812

Hey all, dev here of Speedtest Tracker. Happy to answer any questions to help get the helm chart finished.

Couple of quick thoughts:

  • Your reference to the cache driver in the config directory is the supported drivers. I suggest using either file for single node instances or database for multiple. Redis can be used for more "advanced" setups.
  • When you've rolled this out can someone open an issue on the main repo so I can add it to the docs? Currently I don't have any TrueNAS instructions.

alexjustesen avatar Feb 27 '24 12:02 alexjustesen

Hey all, dev here of Speedtest Tracker. Happy to answer any questions to help get the helm chart finished.

Couple of quick thoughts:

  • Your reference to the cache driver in the config directory is the supported drivers. I suggest using either file for single node instances or database for multiple. Redis can be used for more "advanced" setups.
  • When you've rolled this out can someone open an issue on the main repo so I can add it to the docs? Currently I don't have any TrueNAS instructions.

An error i noticed when trying to run the app (have it running as a custom app). Is that i always get the following error during startup.

image

is this an issue of the container in general? the container is running as root and its an directory which isnt even mounted in your setup. Also is there any indication if redis/database is used proberly? (didnt see anything in the log in test)

Truecharts also does general Helm Charts. So this Chart wont only be available on TrueNas Scale but also Kubernetes Os (like TalosOs)

alfi0812 avatar Feb 27 '24 12:02 alfi0812

ill merge for now and see if that nginx path may be an issuer after

xstar97 avatar Feb 27 '24 16:02 xstar97

@allcontributors please add @alfi0812 as a contributor for code

StevenMcElligott avatar Feb 27 '24 21:02 StevenMcElligott

@StevenMcElligott

I've put up a pull request to add @alfi0812! :tada:

allcontributors[bot] avatar Feb 27 '24 21:02 allcontributors[bot]