charts
charts copied to clipboard
feat(cs2): add RCON to cs2
Description The RCon connection wont establish when the TCP port isn't listening ⚒️ Fixes #
⚙️ Type of change
- [x] ⚙️ Feature/App addition
- [ ] 🪛 Bugfix
- [ ] ⚠️ Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] 🔃 Refactor of current code
🧪 How Has This Been Tested? I manually edited the deployed service to input the TCP port mapping, to confirm that is what is needed.
✔️ Checklist:
- [x] ⚖️ My code follows the style guidelines of this project
- [x] 👀 I have performed a self-review of my own code
- [ ] #️⃣ I have commented my code, particularly in hard-to-understand areas
- [ ] 📄 I have made corresponding changes to the documentation
- [ ] ⚠️ My changes generate no new warnings
- [ ] 🧪 I have added tests to this description that prove my fix is effective or that my feature works
- [x] ⬆️ I increased versions for any altered app according to semantic versioning
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
3 out of 4 committers have signed the CLA.
:white_check_mark: Ornias1993
:white_check_mark: TheSinding
:white_check_mark: xstar97
:x: Simon Sinding
Simon Sinding seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.
Please follow our standards when creating prs, title and random checkboxes checked on stuff you didn't do is unecessary.
@xstar97 I have done some changes, see if that fits.
Next time mate, instead of saying "Too random", try and be more constructive in the way you approach this. I'm sorry it didn't live up to your standard and that I haven't read the contribution guide lines in such details.
Maybe consider adding them to the README.md so people don't have to go look for them on your website.
Do i need to add something to the questions.yaml
aswell ?
I could imagine the RCON part of the values should be added to the questions too right ?
@xstar97 I have done some changes, see if that fits.
Next time mate, instead of saying "Too random", try and be more constructive in the way you approach this. I'm sorry it didn't live up to your standard and that I haven't read the contribution guide lines in such details.
Maybe consider adding them to the README.md so people don't have to go look for them on your website.
Drop the attitude
@xstar97 I have done some changes, see if that fits. Next time mate, instead of saying "Too random", try and be more constructive in the way you approach this. I'm sorry it didn't live up to your standard and that I haven't read the contribution guide lines in such details. Maybe consider adding them to the README.md so people don't have to go look for them on your website.
Drop the attitude
Okay, I won't get into a fight with you. Just look at the pullrequest
Main port is 27015, can't reuse it for rcon.
Isnt the default 27020?
If no port is specified, it will run it on port 27015 by default.
That is also the same port the cs2 client tries to connect to if you haven't specified a port when using the rcon
command
RCon runs on the port 27015/TCP, hence why it wasn't working in the first place and the title was fixes. The game data is running on 27015/UDP.
update the env section for GAME_PARAMS like this
add the rcon stuff there + add a rcon_pass field to the cs2: thing. add the same for the questions.yaml
this way we can have rcon has the probes like palworld
needs rebase
Can you check the ports please? @xstar97 If both services main and rcon use the same (but different protocols) its fine. But they need to be on the same service