Felix Schneider
Felix Schneider
Okay, I'm sorry for the many commits (Vercel build minutes) HiDeoo, but I think I got the most features covered from #74
Some thinks to note down before merging: - there is currently the inconsistency that the reading time has a space between the number and string: `2 min` or `1 h`...
It's probably better to wait with this feature until the route data is moved to `Astro.locals` in Starlight. After the refactoring of the plugin, it's easier to implement this feature...
I'm also very excited about this PR! Just to keep track of what has been achieved already and what needs to be done after reading the latest changes: - [x]...
I have really been looking forward to this PR for a some months, writing a lot with HiDeoo about how **powerful** these changes actually are. In my opinion, @HiDeoo describes...
Also, [I have a small suggestion](https://github.com/withastro/starlight/pull/2778) which I think should be discussed in the mentioned PR, not here...
> Shouldn't the examples include a call to next() at the end to enable possible chaining? I think as Chris mentioned in the description, that the for loop handles all...
> How breaking must a change be to justify a major version change? š¬ I'm not entirely sure how the Starlight maintainers see this, but I think right now Starlight...
> I think the example you're suggesting is more of a plugin author taking advantage of the Astro feature rather than the new Starlight change in this case. That's a...
Quick comment: I love the documentation addition from https://github.com/withastro/starlight/commit/a7eebada417e93368d568690a64bb4141e1da91b Really nice example š