NAHO
NAHO
> Another approach is to infer the polarity based on the contrast between `base00` (background) and `base05` (foreground). If `base00` is darker then it's a dark theme, if it's lighter...
> Actually, I've realized that we're talking about two different things here: `stylix.polarity` and `stylix.colors.variant`. `stylix.polarity` is specified by stylix, but `stylix.colors.variant` is specified by tinted-theming. Unless there's a breaking...
> This feels like it's more of an issue with the overall design of having separate platform & overlay modules, with no place for common shared modules. > > Surely...
> Generally, if you trust someone to maintain a target module, you should trust them with that level of perm. If someone abuses triage perms then they shouldn't be a...
> > Consequently, we are basically adding anyone as module maintainer that is willing to help us out. > > This is no different from nixpkgs maintainers, which operate in...
Thanks for this excellent bug report! Currently, Stylix delegates Helix' theming to https://github.com/tinted-theming/base16-helix: https://github.com/danth/stylix/blob/a2d66f25478103ac9b4adc6d6713794f7005221e/modules/helix/hm.nix#L4-L6 Consider patching the [upstream theme](https://github.com/tinted-theming/base16-helix/blob/7f795bf75d38e0eea9fed287264067ca187b88a9/templates/default.mustache) and then submitting a Stylix PR to update the `base16-helix` input.
> I’m unsure how to choose the colors for each module. Are they opinion-based? Until https://github.com/danth/stylix/issues/249 is resolved, the [Style Guide](https://github.com/danth/stylix/blob/0ce2a52decf36d815065f8cda06586ed59ed3ef7/docs/src/styling.md) is the best we have. Essentially, choose the colors...
> > For predefined themes, you might need to set the values manually though for each module. But you can easily do that by requesting the wanted value like so:...
Cc: @Flameopathic @MattSturgeon
> But if you are going to, then perhaps it's better to stop treating the target modules as, well, modules. Instead do what @trueNAHO suggested and make those files a...