manual-approval icon indicating copy to clipboard operation
manual-approval copied to clipboard

No reaction on comments

Open Woitekku opened this issue 3 years ago • 4 comments

Hey,

I'm using it with following:

        uses: trstringer/manual-approval@v1
        with:
          secret: ...
          approvers: ...
          minimum-approvals: ...
          issue-title: ...
          exclude-workflow-initiator-as-approver: false

The 1.8.0 version is in use. Once the issue is raised, and a comment like "approve" is placed, nothing is happening. There is no another action from bot, that would close the issue and move forward the pipeline, it will stay in waiting for 6hrs.

What is wrong? Is it a bug or am I missing something?

Woitekku avatar Nov 28 '22 13:11 Woitekku

oh i guess i found the issue exclude-workflow-initiator-as-approver: false

Woitekku avatar Nov 28 '22 13:11 Woitekku

no; it should be false, as per default to be able to do self-approval...

Woitekku avatar Nov 28 '22 13:11 Woitekku

Can you confirm what the list of approvers are on the actual issue itself?

trstringer avatar Jan 20 '23 12:01 trstringer

Hi @Woitekku

Do you have any inputs for us, The additional Information requested by thomas will help us in debuging this issue.

snskArora avatar Jun 13 '25 22:06 snskArora