manual-approval icon indicating copy to clipboard operation
manual-approval copied to clipboard

Timeout setting does not work

Open alexkuklin opened this issue 1 year ago • 10 comments

I've set

         timeout-minutes: 3

and it does not seem to work out. Cancelled it manually after 7 minutes:

Tue, 04 Oct 2022 14:03:25 GMT
Respond "approved", "approve", "lgtm", "yes" to continue workflow or "denied", "deny", "no" to cancel.
Tue, 04 Oct 2022 14:03:26 GMT
Workflow status: Pending
...
Tue, 04 Oct 2022 14:10:28 GMT
Workflow status: Pending
Tue, 04 Oct 2022 14:10:35 GMT
Workflow cancelled, closing issue.
Tue, 04 Oct 2022 14:10:37 GMT
Error: The operation was canceled.

alexkuklin avatar Oct 04 '22 14:10 alexkuklin

Did you check that the timeout-minutes located outside of the with: block? See #48.

      - uses: trstringer/manual-approval@v1
        timeout-minutes: 5

sheeeng avatar Oct 10 '22 08:10 sheeeng

Thanks for helping, @sheeeng! @alexkuklin, did that work for you?

trstringer avatar Oct 27 '22 19:10 trstringer

Thanks for helping, @sheeeng! @alexkuklin, did that work for you?

not yet, will do, thanks

alexkuklin avatar Oct 27 '22 19:10 alexkuklin