Issue to approve/decline is not closed automatically

[iuriipaniukov]

We are using the action with those props:

- uses: trstringer/manual-approval@v1
  with:
      secret: ...
      approvers: ...
      issue-title: ...

but after a job is declined I expect the issue should be closed automatically if there were no reaction. Unfortunately, some of them are not closed.

What might be the issue?

Thank you!

[trstringer]

This should have been resolved in https://github.com/trstringer/manual-approval/pull/4 but it sounds like that may not be the case. I'll look into this and see if I can repro it!

[iuriipaniukov]

If the pipeline/job is canceled the task is closed automatically, but not if time is off

[trstringer]

What do you mean "not if time is off"? You mean if the job reaches the timeout?

[iuriipaniukov]

yes