manual-approval Allow anyone to approve

Make the approvers field optional, and allow anyone to approve if it's empty.

I had to rework approvalFromComments to make this work, since it worked by removing names from the required approvers list until the list was small enough.

closes https://github.com/trstringer/manual-approval/issues/108

Apr 15 '24 17:04 philn-delphia

What kind of testing did you do for this PR? And also thanks for contributing!

Jun 19 '24 21:06 trstringer

bump, this would be a nice feature :)

Jul 18 '24 18:07 zchenyu

What kind of testing did you do for this PR? And also thanks for contributing!

I've been using this internally with no issues, but honestly we always have it set to allow all reviewers since it's private repos.

Sep 05 '24 16:09 philn-delphia

Hello, bumping as it'd be really helpful for me. Is there anything blocking us from merging it?

Jan 02 '25 09:01 MichalLeszczynski

Also, please rebase on the main branch to account the new changes.

Mar 01 '25 19:03 snskArora