manual-approval icon indicating copy to clipboard operation
manual-approval copied to clipboard

Can't get the approval values

Open MamadouSadio opened this issue 2 years ago • 8 comments

Please can someone explain me how can i get the approval values (yes, approve...) when i click on the approve and deploy button in the Review pending deployment pop up. I want to make some conditions with it in my following step but it doesn't work and i don't see any example about that in the docs. I got always a pending status in Manual Workflow Approval step before fail.

MamadouSadio avatar Aug 08 '23 07:08 MamadouSadio

I am also facing the same issue

G-Gowtham avatar Aug 18 '23 05:08 G-Gowtham

It's taking so much time just to get a reply

MamadouSadio avatar Aug 18 '23 14:08 MamadouSadio

I am also facing the same issue

Hi @G-Gowtham Are you find a eventual solution ?

MamadouSadio avatar Aug 25 '23 09:08 MamadouSadio

Sorry, I'm not understanding the problem. You can't find the approval keywords? Those are hardcoded.

trstringer avatar Oct 19 '23 02:10 trstringer

@MamadouSadio @trstringer It seems I can't able to approve the request which is created by myself even though I am a assignee.

G-Gowtham avatar Oct 19 '23 08:10 G-Gowtham

@MamadouSadio @trstringer It seems I can't able to approve the request which is created by myself even though I am a assignee.

I'm experiencing the same, can't seem to approve the workflow at all.

Casperjuel avatar Oct 24 '23 11:10 Casperjuel

Were you guys able to figure out what the problem is? - The action opens the issue successfully for me - but it won't register when I comment a 'approve' or 'approved' keyword in order to continue the workflow, I've also set 'exclude-workflow-initiator-as-approver:' to false - but no luck.

So I figured out the reason was that I had set myself in the approvers field as 'velink' but it is case-sensitive so updating it to 'Velink' fixed it.

Huge thanks to the @trstringer for creating this - it will save me $100 a month not having to get GitHub Enterprise. The only feature my team required from Enterprise is the manual approval step to deploy to production, and we wouldn't have utilised any of the other features offered by Enterprise just had to pay for them which would have been a waste.

Velink avatar Nov 25 '23 18:11 Velink

Got the issue, too. The approvers field is case-sensitive.

JoHuang avatar Apr 19 '24 13:04 JoHuang

I want to make some conditions with it in my following step but it doesn't work and i don't see any example about that in the docs.

That's because this doesn't exist yet - I have a PR open that does this though! https://github.com/trstringer/manual-approval/pull/147

lizziemac avatar Feb 13 '25 14:02 lizziemac

getting the same issue when I comment 'approve' or 'approved' keyword in order to continue the workflow. Is this will be resolved anytime soon ?

dev-isha-07 avatar Mar 20 '25 23:03 dev-isha-07

This issue was resolved on the code level in Feb, but the release was created in the last week of May, so now you shouldn't be experiencing the issue.

If you still face the issue, please open an issue again, closing this for now

snskArora avatar Jun 13 '25 21:06 snskArora