Thomas Shafer

Discussion: Operator cli installation steps

14

There are two fundamental pieces to consider: 1. Ease of installation. From the [2019-06-24 meeting notes](https://docs.google.com/document/d/1DoCG0VGZ0_Nj84Ci443bEefSOnJAWVDXUbcYR-viVfY/edit#heading=h.g130s4kmuni6): "Plain install, it should just work" 2. Ease of customization. Having the operator just...

Operator should validate cluster before installing knative serving

3

If the cluster is not setup to support the intended version of knative it should report an error status. When the user applies the `KnativeServing` CR, ```YAML apiVersion: serving.knative.dev/v1alpha1 kind:...

Discussion: Installation of monitoring

2

Should the operator be responsible for updating the prometheus config, such as https://github.com/knative/serving/blob/befc0822427d7c6a712e73538d98444bf37aaeb3/config/monitoring/metrics/prometheus/100-prometheus-scrape-config.yaml

added component functions to manipulate selected list

1

changed defaultSelected to no longer modify the selected list after the first render I accidentally fell into the trap of https://facebook.github.io/react/tips/props-in-getInitialState-as-anti-pattern.html hey @fmoo this is no longer backward compatible with...

Rename master branch

1

Rename master branch to main given guidance on https://github.com/github/renaming.

Add test for getDrugPK

1

Remove default values for getDrugPK, these are required values and should be forced to be passed in.

The reactive value `drugs` is set from both of these functions. There should be enforcement that these two functions return the same data types. https://github.com/StevenLShafer/stanpumpR/blob/9fe8753b3315c4918858218676ef0649b0f57bd4/server.R#L248-L256 https://github.com/StevenLShafer/stanpumpR/blob/9fe8753b3315c4918858218676ef0649b0f57bd4/server.R#L392-L400