Thomas Shafer

Results 37 comments of Thomas Shafer

You may be falling for https://facebook.github.io/react/tips/props-in-getInitialState-as-anti-pattern.html . There's an unofficial API for setting the text: https://github.com/fmoo/react-typeahead/blob/master/src/typeahead/index.js#L108 I don't exactly know how it works in your case for componentDidMount, but for...

Hey @fmoo I rebased off master. Ready to merge when you're ready, assuming you like the additions.

I thought I still had my benchmark for https://github.com/fmoo/react-typeahead/pull/125 . I can recreate it and send it here.

`npm install benchmark` And here's a benchmark shell with an initialized typeahead. ``` js var Benchmark = require('benchmark'); var React = require('react'); var ReactTypeahead = require('../lib/react-typeahead').Typeahead; var TypeaheadElement = React.createElement(ReactTypeahead);...

Apologies @alexjg. didn't know you were looking for feedback. I'm in family vacation at the moment. Will check back in a week. If you don't hear back ping me again.

+1. I could see a use case for adding the same value multiple times, but I think the default use case should be to not return results that have already...

ReactTransitionGroup uses `component={component}` as the prop name when rendering a different component: https://facebook.github.io/react/docs/animation.html#rendering-a-different-component . Just a thought instead of `CustomComponent`.