Thomas Shafer

Results 37 comments of Thomas Shafer

Github automatically changed the bottom line using the in-browser editor.

I added a test, but didn't run it. I actually have no idea if this code works. :-/

Another option is to not install the `knative-ingress-gateway` (https://github.com/knative/serving/blob/b7dfe3fdb80ffac7f7a05c20787400ce51aad2b1/config/202-gateway.yaml#L19) if one is already configured, . And use that gateway instead of the `knative-ingress-gateway`.

2 - merge. Agree with @duglin. I think eventing will become more expected when "installing knative" as eventing grows. The goal of a kubernetes operator is to automate what a...

I should provide some thoughts on why we would not want to merge the eventing and serving operator. Eventing and serving could have different release cadences. If the operator is...

> Operator should perform the checks before installing Knative Serving. Yes. I am open to the idea of updating the `KnativeServing` CRD to add the desired dependency configuration. @houshengbo @greghaynes...

I think so, it makes sense for knative to support a range of istio installations. Probably makes sense to be a wildcard on `patch`. Currently the installation guide supports one...

The third number in a release: `Major.Minor.Patch`.