Troy Ready
Troy Ready
I'm pretty sure the failing race condition test is expected due to the deadlock induced in the new test. I'm torn about best way to fix it: * Could disable...
The behavior here seems well intentioned and may be the most user-friendly thing possible, but it's prescriptiveness still gives me pause. Would it be worth considering changing given the hassle...
After you mentioned coming back to stacker in Slack, I started thinking about the on-boarding experience and came to many of the same conclusions. Strongly agree about the `init` subcommand...
I like the `cast` idea. Would meet the need here in a simple way, and could always be cast off (pun not intended) in the future if it was made...
Unhelpful background to start: the template_path is modeled after the class_path behavior: first one matching/found is used. If the paths aren't specific enough in either scenario, it'll be unpredictable and...
A colleague of mine had similar designs to associate the template_path (or class_path) with a particular package_source. Some sort of metadata on the package_source that could be referenced in the...
Possible duplicate of #688 ?
My 2c: I'd be in favor of putting off #496 until Stacker v2, to minimize the changes to currently deployed stacks. It's not really A Big Deal, but since the...
@ejholmes I really like your previous PoC (putting the stacker bucket stack in the dag), but I'm way fine with this simple recommendation as well.
I'd prefer this to go into a 2.0 branch, since it technically changes existing behavior (there may be users deploying to oregon/etc that have parameters in virginia and are relying...