PHRETS icon indicating copy to clipboard operation
PHRETS copied to clipboard

php 8.x deprecated errors

Open thepofo opened this issue 2 years ago • 1 comments

Would it be possible to update the code to make it PHP 8.x compatible?

I have the following deprecated error: some examples:

Deprecated: Return type of PHRETS\Models\Search\Results::offsetExists($offset) should either be compatible with ArrayAccess::offsetExists(mixed $offset): bool, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in C:\Users.......

Thx Eric

thepofo avatar Mar 11 '22 07:03 thepofo

I second this.

jonathanmelville avatar May 11 '22 20:05 jonathanmelville

I agree. There is PHP 8.2 coming soon, and some of these deprecations may become warnings or even errors

PAXANDDOS avatar Nov 16 '22 15:11 PAXANDDOS

In the readme file it says the following PHP versions are supported:

PHP 5.6, 7.0, 7.1 and 7.2 supported

Would making things compatible with PHP 8+ break things for users still on PHP 5? If so, would it make sense to move this potential update to a 3.0 version and drop PHP 5 support completely?

pixelprogrammer avatar Dec 01 '22 17:12 pixelprogrammer

I agree. There is PHP 8.2 coming soon, and some of these deprecations may become warnings or even errors

Support for 8.1 will never arrive.

maietta avatar Mar 18 '23 00:03 maietta

These are addresses in the most recent release.

troydavisson avatar Aug 23 '23 12:08 troydavisson