Troy Chaplin
Troy Chaplin
I have completed a second review, tested the code, and made 1 change in the JS snippet as it was missing a sinlge quote
First thing that comes to mind is to use `Prepare to Publish`, which would default to just `Publish` if the pre-publishing checks have been disabled in the preferences.
Oh I didn't noticed the para either and I already PR'd a fix based on using `display: inline-flex` and `align-items: centre`.
> [@troychaplin](https://github.com/troychaplin) I think it's still a good idea to switch the button to inline-flex. I had overridden it personally in my front-end theme, but I hadn't done so in...
I agree with @t-hamano and also prefer the first option as the alignment is tied directly to the image. It seems out of place in the formats drop down, I...
@t-hamano I've finished changes in PR #70868 based on your idea in option 1 using a combination of `ToggleGroupControl` and `ToggleGroupControlOptionIcon` components. I'm having issues with a couple tests, and...
I have moved my PR to draft and am happy to continue working on (or reworking) based on which direction is decided.
> Thank you [@troychaplin](https://github.com/troychaplin) for doing that. Not saying it can't be shipped, more we have to make sure of consistency. Draft PRs are great way to explore. I know...
## Tutorial/Lessons Review Checklist Please tick all items you've confirmed: - [x] Learning outcomes/objectives are clear. - [x] Technical concepts introduced in the content are accurate. - [x] The speed...
I just watched this video over a few times and it's really well put together. Clear and to the point without being complicated, and done at a great pace.