Troy Connor

Results 47 comments of Troy Connor

I've done it, just so I can use the .then instead of the callback signature. Performance seems to be the same. Here is a project I used it in https://github.com/troy0820/fixit/blob/master/request-promise.js

+1 with what @jaumard said. I like tent :+1:

Question concerning the fork one. Do we want to do that? Big `issue` about this being an unintentional fork of sails (I know it's not but you know). Didn't want...

Right now there is a PR that is up for added `204` as success. @arhea is the reviewer and the next version bump should fix this issue.

We have a lot of functions that do what this package does such as `removeFinalizer` which actually uses the package in question. If we want to standardize around this to...

@willie-yao I was going to create an issue for the azuremanagedcluster_controller unit test and assign it to myself. I can update this issue when that is done.

The issue is linked above but here is the link to edit the intial description: https://github.com/kubernetes-sigs/cluster-api-provider-azure/issues/4270

New issue created https://github.com/kubernetes-sigs/cluster-api-provider-azure/issues/4277 PR is coming soon.

New issue created https://github.com/kubernetes-sigs/cluster-api-provider-azure/issues/4290 PR is coming soon