Aaron Piotrowski

icon indicating an email [email protected]

icon company @amphp icon location Minnesota icon location Computer programmer, photographer, and coffee lover. Maintainer of @amphp, a library for writing async code in PHP using fiber-based coroutines.

Results 147 comments of Aaron Piotrowski

Transactions won't work if \pg_get_result returns multiple results

Multiple result sets from queries are now supported in the `2.x` branch of this library. A few betas have been released, with a stable to be tagged in the coming...

Closing connection during a long running query blocks the loop

#54 has been merged and tagged under `v1.4.5`.

Missing commands

Looks like we forgot to close this after merging these commands in #77. Tagged as `v1.1.0`.

Missing commands

No, it seems I either forgot to push or the push failed. Since I didn't actually tag, should we review and make changes to #78, merge, then tag?

32 bit PHP: Return value of Amp\Loop\NativeDriver::now() must be of the type int, float returned

Are you running on a 32-bit install of PHP? If so, I would have expected some warnings from https://github.com/amphp/amp/blob/c5ea79065f98f93f7b16a4d5a504fe5d69451447/lib/Internal/functions.php#L81-L85

Allow referencing a TimeoutCancellation

I think reference and unreference methods similar to Socket would make sense on `TimeoutCancellation` and `SignalCancellation`. Perhaps no constructor parameter at all then?

Add PriorityQueue

We could, though I hesitate to provide extra tools in `revolt/event-loop` which aren't directly related to the loop API. We could make it a separate library under Revolt. What do...

Add PriorityQueue

Quick note: The revolt loop uses a similar class, but is tailored for `TimerCallback` objects and uses floats for timer expirations. We could use this implementation there, but it would...

Add PriorityQueue

Moving this to `amphp/sync` instead, see https://github.com/amphp/sync/pull/27.

Under XAMPP 8.2.4 the first example program freeze

I do not have any experience using XAMPP, and I suspect that creating child processes within XAMPP and PHP may not be supported. Apache typically runs PHP through a module...