Henric Persson comments

Results 310 comments of


                                            Henric Persson

Meteor environment should auto-exclude some directories

I think we could start implementing a merged approach. The point about users possibly wanting to override excludes is a valid one but I think the pragmatic approach right now...

Meteor environment should auto-exclude some directories

That `egrep` command is only being applied to the list of files returned by the `find`, so we'll have to do more than expand that.

My import-js can't find a component unless it runs on atom.

This is unfortunate. It has to do with the cache being cold. On first use, import-js will kick off a background thread indexing modules in your project structure. So on...

when i move a personal module file to an other folder, the import suggestion of the personal module propose the old folder and the new folder

Are you using watchman by any chance? (see docs here: https://github.com/Galooshi/import-js#things-to-note) I'm using watchman and haven't noticed this issue.

Improve CLI documentation

The docs for the CLI tool are thin, I agree. I’d be happy to accept a PR updating the readme file!

Add line number to `goto`

I like this idea, and I wonder if we could make a cheap test in one of the clients before we try it out? Clients now what variables they go...

append to import list?

@ivangeorgiew do you want to push that as a PR? I'm happy to review and merge.

fixImports issues

Again, thank you for finding and reporting all these issues!

Should never suggest the same file to import

Good point. This should be pretty easy to fix. We have to be a little but careful about comparing directly against `path_to_current_file` because I'm not sure all editor plugins pass...

Trouble working with webpack aliases

I suggest looking into using the `aliases` configuration option: https://github.com/Galooshi/import-js/blob/master/README.md#aliases