go-links icon indicating copy to clipboard operation
go-links copied to clipboard

updated validators library version to be 0.18.1

Open kentoku24 opened this issue 5 years ago • 5 comments

fix #54

0.12.0 does not treat punycoded URL. The latest 0.18.1 correctly recognize punycoded URL.

example: https://xn--wmq0m700b.jp/h30

kentoku24 avatar Oct 06 '20 16:10 kentoku24

@kentoku24 thanks again! Did this solution work for you locally? I still get that error and think this line needs to also be removed (though .strip()ing the destination should be retained): https://github.com/trotto/go-links/blob/bc7145cb0a35d1d19a86cb023a3335a680f02c4f/server/src/modules/links/helpers.py#L98

I believe that scrubbing is a relic from when Trotto was using a different database and can now be removed. You'll also need to update related tests.

itsojon avatar Oct 06 '20 17:10 itsojon

thank you for the feedback. I will look into this too!

kentoku24 avatar Oct 07 '20 01:10 kentoku24

Thank you @kentoku24! Don't hesitate to send me any questions.

itsojon avatar Oct 07 '20 13:10 itsojon

Sorry to take forever to reply to you, but how could I run the tests? I found e2e test but stuck at setting "secret". Does trotto has unit tests that runs locally?

kentoku24 avatar Aug 22 '21 12:08 kentoku24

@itsojon

Did this solution work for you locally? I still get that error and think this line needs to also be removed (though .strip()ing the destination should be retained): It certainly worked in my local environment. Have you re-installed the libraries with pip command?

After bumping the version to 0.18.1 スクリーンショット 2021-08-22 23 18 47

kentoku24 avatar Aug 22 '21 14:08 kentoku24