Simon Hausmann

Results 493 comments of Simon Hausmann
trafficstars

I can think of four different ways of writing a "dynamic" grid layout: 1. Create a variable number of rows: ```60 GridLayout { for item in model: Row { //...

I think that this is the right direction. It looks like a substantial effort though. I like that this enables a stepwise iteration through the tree. > I hope this...

> Do we need to be able to implement repeaters in C++ code? The model type in C++ is a template on the contained data type, which is a good...

I couldn't quite find "the official" theme but many people making their own. The Fluent UI Theme Designer seemed like the easiest way to map existing palette and introduce a...

Ah i see that at the very least this needs fixing of the Button to work with this.

Alternatively I need to understand what https://docs.microsoft.com/en-us/fluent-ui/web-components/getting-started/styling#light-and-dark-mode would do.

I'm tweaking this further. A darker shader for "white" and lightening up the neutralLight shades gives a nice contrast for the button. This is also a good reference https://github.com/microsoft/fluentui/issues/9795#issuecomment-511586994

> Although the native style had the problem already then. > > Perhaps this should be opt in somehow? Or we just do it anyway. Yeah, I think we should...

Bonus: Also made a fix for the AboutSlint logo

This crashes because the `NativeStyleMetrics` are now used and instantiated from multiple testing threads. We need to move the dark mode detection into corelib.