Simon Hausmann

Results 390 comments of Simon Hausmann

Fair point, but is `released` the right name? Shouldn't this also be invoked when the slider knob is moved by the keyboard?

Flutter has two callbacks for this, `onChangeStart` and `onChangeEnd`. That's not really a pattern we use, but in the light of that a plain `released` callback that's invoked when the...

@flukejones looks like we're good then. I see three missing pieces: 1. [x] The tests are failing because the Qt bits are missing. 2. [x] There's no documentation (in `slider.md`)....

No worries. Just let me know when you'd like me to take over (at any point).

I think that this is ready for review. But since I had my dirty hands in it, it would be good if @ogoffart could do the honours of finding bugs...

Continued in https://github.com/slint-ui/slint/pull/4821

Hmm, I've never seen this crash before. The crash points into Skia itself, which is concerning. Could you try building with `SKIA_DEBUG=1`? You'll get some build error inside Skia headers...

Minimal testcase, indeed: ``` export component App { Text { text: "🍃"; } } ```

``` * thread #1, name = 'main', queue = 'com.apple.main-thread', stop reason = EXC_BAD_ACCESS (code=1, address=0x0) frame #0: 0x00000001006565ab slint-viewer`SkFontMgr::matchFamilyStyle(this=0x0000000000000000, familyName="Apple Color Emoji", fs=0x00007ff7bfeeec30) const at SkFontMgr.cpp:111:18 108 109 sk_sp...

Another option would be to have an enum instead of a boolean, like `enum ColorScheme { Dark, Light, Unknown }`, but that's a little weird for the setter.