OpenXLSX icon indicating copy to clipboard operation
OpenXLSX copied to clipboard

extend testing, add new function

Open ofenloch opened this issue 2 years ago • 2 comments

use std::filesystem to delete files before creating them

extend XLFormula tests

add function converting a string in a cell to a proper formula

ofenloch avatar Aug 04 '22 13:08 ofenloch

It might be beneficial to use a flag to use filesystem as it's a relatively new API. TDM-GCC doesn't implement filesystem for C++17 if I remember correctly.

Or this might be an option: https://github.com/gulrak/filesystem

This should allow a consistent implementation across Windows, MacOS and Debian

SimantoR avatar Oct 09 '22 14:10 SimantoR

@SimantoR

It might be beneficial to use a flag to use filesystem as it's a relatively new API. TDM-GCC doesn't implement filesystem for C++17 if I remember correctly.

Or this might be an option: https://github.com/gulrak/filesystem

This should allow a consistent implementation across Windows, MacOS and Debian

The CMakeLists.txt specifies C++17. Even if there are compilers not implementing the standard completely I don't think it's a good idea to deviate from the standard - although it might be benificial.

ofenloch avatar Nov 01 '22 10:11 ofenloch