oink icon indicating copy to clipboard operation
oink copied to clipboard

Adding priority promotion en Zielonka variants with justifications.

Open Rupsbant opened this issue 5 years ago • 3 comments

Hi,

I would like to add two, or three, justification variants to Oink: Oink-ppj is a priority promotion variant, Oink-zlkj is a variant of Zielonka's algorithm with a hashset and Oink-zlkjb is a non-hashset variant.

The application of justifications to parity games has been described in "Improving Parity Game Solvers with Justifications."

I would be happy to explain and modify the source code to match your requirements.

Kind regards Ruben

Rupsbant avatar Jan 18 '20 16:01 Rupsbant

Hi @Rupsbant, I tried importing but it does not compile? You moved the struct out of the header file to the implementation, but this breaks compilation. Just adding the struct without content seems to work though. Haven't done a more detailed check yet. However I did also test quickly on my development branch and it seems to pass the random test bench as well as the internal tests, so that's good.

trolando avatar Feb 17 '20 12:02 trolando

Oh another comment. It might be nicer to split the two/three solvers into separate commits, and have slightly improved commit messages. Keeps the master branch nice and clean, hopefully.

trolando avatar Feb 17 '20 12:02 trolando

I hope to get to this soon, pinky promise.

trolando avatar Jun 18 '24 19:06 trolando