oink

oink copied to clipboard

Work on the DFTL (distraction-free tangle learning) algorithm. This was a rather tricky algorithm to study, but unfortunately it admits an exponential lower bound following fibonacci's sequence. This counterexample doesn't...

trolando

Adding priority promotion en Zielonka variants with justifications.

3

Hi, I would like to add two, or three, justification variants to Oink: Oink-ppj is a priority promotion variant, Oink-zlkj is a variant of Zielonka's algorithm with a hashset and...

Rupsbant

[Here](https://github.com/trolando/oink/blob/master/test/test_solvers.cpp#L252). You don't set the C++ standard level, so when the compiler defaults to C++20, the compilation fails: ``` /wrkdirs/usr/ports/math/oink/work/oink-3327c54/test/test_solvers.cpp:250:19: error: no member named 'random_shuffle' in namespace 'std' else std::random_shuffle(files.begin(),...

yurivict

The target "oink" links to: lace::lace but the target was not found

5

This is because the build is done on an unconnected system where FetchContent doesn't work. The correct way is to add it as git submodule, so that it would be...

yurivict

Should use C11 atomics

8

The project currently uses haphazardly hand-crafted atomics using `volatile` variables. This is not guaranteed to work correctly and is unportable. Consider migrating to C11 atomics if possible.

clausecker

clang-11 prints many warnings

1

Log: https://people.freebsd.org/~yuri/oink.log

yurivict

Performance improvement qpt.cpp

3

Notation: `au(b,pv)` is the antagonistic update of a progress measure `b` with priority `pv`. `pm(w)` is the current progress measure of `w` and `pr(v)` is the priority of `v`. If...

Rupsbant

This initializes `opt_workers` to 0: https://github.com/trolando/oink/blame/257d0d088361204449c9bb204b457c2042e26cae/test/test_solvers.cpp#L53 The documentation reads: ``` -w, --workers arg Number of workers for parallel algorithms, or -1 for sequential, 0 for autodetect (default: -1) ```

michaelcadilhac

Valgrind reports: ``` ==2052526== Conditional jump or move depends on uninitialised value(s) ==2052526== at 0x1B547D: pg::Game::set_priority(int, int) (game.cpp:276) ==2052526== by 0x1B52EE: pg::Game::init_vertex(int, int, int, std::__cxx11::basic_string) (game.cpp:263) ==2052526== by 0x1B4FD4: pg::Game::init_random_game(int,...

michaelcadilhac