trois icon indicating copy to clipboard operation
trois copied to clipboard

Use vue-demi for Vue 2

Open mahapo opened this issue 4 years ago • 4 comments

It would be nice if Vue 3 imports could be replaced with vue-demi. So the plugin also can be use with Vue 2/Nuxt. https://github.com/vueuse/vue-demi

mahapo avatar Jun 03 '21 15:06 mahapo

Thanks, already tried but didn't had time to finish my tests, and not so easy because I use a mix of Composition and Option API

klevron avatar Jun 03 '21 19:06 klevron

Hi, I'd like to help with this issue if that's okay @klevron? Given what you said about using the mix of composition and options API, would it make sense to start converting everything to just use the composition API with the vue-demi shim?

sarayourfriend avatar Feb 26 '22 18:02 sarayourfriend

Hi 👋

Any update on this @klevron @sarayourfriend ? 🙂

glumb avatar May 26 '23 11:05 glumb

I did quite a bit of "exploratory coding" to try to accomplish this but without @klevron's buy in I decided I wouldn't continue. As they said, there are significant changes required to the structure of various components, including re-writing non-trivial mixins and other Vue 2 specific abstractions. Either this would be a single massive PR (which would be a pain to maintain with conflicts, etc) or should be done piecemeal. My own need for Vue 2 support will be gone soon, however, as WordPress/Openverse should be able to move to Vue 3 at some point later this year and I'm not sure how much I would be able to help with this if that happens.

sarayourfriend avatar May 28 '23 22:05 sarayourfriend