transitions icon indicating copy to clipboard operation
transitions copied to clipboard

new feature: put exception as a param to event_failed

Open lksv opened this issue 10 years ago • 1 comments

I may want to propagate some exceptions and others I may want to handle in event_failed callback.

I am not sure whether catching exception at all is good idea. Maybe best solution would be to re-raise exception after calling event_failed.

lksv avatar Aug 26 '15 14:08 lksv

Sorry for the late reply, I kind of missed this one!

I may want to propagate some exceptions and others I may want to handle in event_failed callback.

Yes, makes sense. Care for a pull request? ;)

I am not sure whether catching exception at all is good idea. Maybe best solution would be to re-raise exception after calling event_failed.

I'm not so sure about this. But then again, if we pass the exception to event_failed it's up to you if you want to just re-raise yourself at the end of the callback. What do you think?

troessner avatar Feb 23 '16 20:02 troessner