reek icon indicating copy to clipboard operation
reek copied to clipboard

Can we move Dockerfile so it has a name that somehow says codeclimate?

Open mvz opened this issue 7 years ago • 2 comments

This is not urgent, but I'd like to move the Dockerfile so its purpose is more clear and to optionally have that filename free for e.g. creation of a testing container or whatever. I don't know if that's possible according to the codeclimate spec.

This is part of a larger goal I have of having the codeclimate stuff in one place rather than mixed with the rest of the reek code base.

mvz avatar May 25 '17 16:05 mvz

👋

Feel free to check the etsy/phan project's approach for keeping the codeclimate stuff isolated: https://github.com/etsy/phan/tree/master/plugins/codeclimate

We can update our internal build process to make it aware of a similar change to reek - we just need a build command. For phan it's:

cd plugins/codeclimate && docker build --no-cache  .

maxjacobson avatar May 25 '17 16:05 maxjacobson

Hi @maxjacobson, that's great to hear. I'll take a look at what phan did and keep you posted if we make any changes.

mvz avatar May 25 '17 16:05 mvz