path-parser icon indicating copy to clipboard operation
path-parser copied to clipboard
verified publisher icon troch

Support for optional query params

Open mrzepinski opened this issue 7 years ago • 3 comments

The query params could be optional I've added an option to test method to support that.

optionalQueryParams is ready to use

mrzepinski avatar Jul 12 '18 05:07 mrzepinski

@troch Is there a way to merge this and release new version?

mrzepinski avatar Jul 12 '18 06:07 mrzepinski

Hi @mrzepinski,

Sorry for being so late to come back to you. Your change is a good addition, however I don't think the option name optionalQueryParams is the best: query params are optional in the sense that not all listed query params need to be provided. Given that another option is called strictTrailingSlash, what about strictQueryParams?

I also wouldn't mind for it to be false by default (and I'll release a new major version).

Does it sound OK to you?

troch avatar Aug 01 '18 07:08 troch

@troch I also have problems with the optionalQueryParams, so strictQueryParams would be very good option. Do you want to make the change?

mrzepinski avatar Aug 01 '18 07:08 mrzepinski