TrixiParticles.jl icon indicating copy to clipboard operation
TrixiParticles.jl copied to clipboard

Pass cross sectional area to `RCRWindkesselModel`

Open LasNikas opened this issue 1 month ago • 1 comments

I noticed that it makes more sense to pass the cross sectional area instead of calculating it with the particle size. Also, it is not correct calculated in main, so this is actually a bug fix.

LasNikas avatar Nov 22 '25 08:11 LasNikas

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 89.60%. Comparing base (32679eb) to head (e0417cb).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #992      +/-   ##
==========================================
- Coverage   89.60%   89.60%   -0.01%     
==========================================
  Files         120      120              
  Lines        8588     8587       -1     
==========================================
- Hits         7695     7694       -1     
  Misses        893      893              
Flag Coverage Δ
total 89.60% <100.00%> (-0.01%) :arrow_down:
unit 64.83% <100.00%> (-0.01%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Nov 22 '25 08:11 codecov[bot]