TrixiParticles.jl icon indicating copy to clipboard operation
TrixiParticles.jl copied to clipboard

Rename 'tlsph' to 'place_on_shell'

Open svchb opened this issue 7 months ago • 4 comments

Fixes #782

svchb avatar May 22 '25 08:05 svchb

Other options would be for example: 'place_on_skin' 'place_on_perimeter' 'place_on_face'

svchb avatar May 22 '25 08:05 svchb

place_on_interface ?

LasNikas avatar May 22 '25 08:05 LasNikas

I would like to avoid words that can be used in another context within our setups. Interface could be also the interface between two fluids or phases.

svchb avatar May 22 '25 08:05 svchb

Codecov Report

Attention: Patch coverage is 80.76923% with 5 lines in your changes missing coverage. Please review.

Project coverage is 70.12%. Comparing base (a91211d) to head (59444e2). Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
src/setups/extrude_geometry.jl 73.33% 4 Missing :warning:
src/preprocessing/particle_packing/system.jl 75.00% 1 Missing :warning:
Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #814   +/-   ##
=======================================
  Coverage   70.12%   70.12%           
=======================================
  Files         106      106           
  Lines        6822     6822           
=======================================
  Hits         4784     4784           
  Misses       2038     2038           
Flag Coverage Δ
unit 70.12% <80.76%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar May 22 '25 09:05 codecov[bot]

/run-gpu-tests

LasNikas avatar Jun 03 '25 09:06 LasNikas

Let's merge all breaking changes to dev while we continue with non-breaking changes on main.

efaulhaber avatar Jun 13 '25 09:06 efaulhaber