Add shifting for `InFlow`-buffer particles
I ran a simulation with a step in the transition zone (see image below). This step induced periodic gaps in the buffer zone which didn't decay. Indeed, the opposite is the case. The simulation is becoming unstable.
So the workaround is to shift not only the fluid particles but also the buffer particles. I only shift particles that are in the vicinity of the transition plane.
Left: No shifting of buffer particle. Right: Shifted buffer particles
Codecov Report
Attention: Patch coverage is 2.12766% with 46 lines in your changes missing coverage. Please review.
Project coverage is 70.22%. Comparing base (
114a57b) to head (683b09c).
| Files with missing lines | Patch % | Lines |
|---|---|---|
| src/callbacks/particle_shifting.jl | 0.00% | 44 Missing :warning: |
| src/schemes/boundary/open_boundary/system.jl | 0.00% | 2 Missing :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## main #768 +/- ##
==========================================
- Coverage 70.60% 70.22% -0.38%
==========================================
Files 106 106
Lines 6769 6804 +35
==========================================
- Hits 4779 4778 -1
- Misses 1990 2026 +36
| Flag | Coverage Δ | |
|---|---|---|
| unit | 70.22% <2.12%> (-0.38%) |
:arrow_down: |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
Can you just cut off the shifting at a point? Is this stable? Or should this be a smooth transition from shifting to no shifting?
Yes, because these buffer particles don't calculate their physical properties physically but extrapolate (Tafuni) them or determine them with a model (Lastiwka). Here, the shifting acts basically as a rearrangement of the position of the particles.