TrixiParticles.jl icon indicating copy to clipboard operation
TrixiParticles.jl copied to clipboard

Shall we move long hard-coded coordinate arrays in the test files to separate files?

Open efaulhaber opened this issue 1 year ago • 3 comments

Hm, we also hard code the coordinates for the RectangularTank tests. Is it worth loading the coordinates from a separate file? It took me a while to generate this, and I need to generate this again for a csv file. Can we leave it as is and if it gets complicated we can still add a separate csv file. @efaulhaber what's your opinion on this?

On the other hand, it's a good point to put coordinates for setup tests in a separate csv file...

Originally posted by @LasNikas in https://github.com/trixi-framework/TrixiParticles.jl/pull/437#discussion_r1547822656

efaulhaber avatar Apr 02 '24 16:04 efaulhaber

A quick thought on this: Most of these long arrays are three-liners, right? So when reading it in an editor without line-wrapping, it's just three lines that one can easily ignore.

efaulhaber avatar Apr 02 '24 16:04 efaulhaber

A quick thought on this: Most of these long arrays are three-liners, right? So when reading it in an editor without line-wrapping, it's just three lines that one can easily ignore.

yes:

image

LasNikas avatar Apr 02 '24 17:04 LasNikas

This depends on the array some will be formatted in a way that they will follow the 90 char length limit.

svchb avatar Apr 03 '24 09:04 svchb